garydgregory commented on code in PR #1553:
URL: https://github.com/apache/commons-lang/pull/1553#discussion_r2659964908
##########
src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java:
##########
@@ -5442,6 +5443,11 @@ void testShuffleStringRandom() {
}
}
+ @Test
+ void testShuffleNull() {
+ assertDoesNotThrow(() -> ArrayUtils.shuffle((byte[]) null));
Review Comment:
Hello @rajucomp
See my previous
[comment](https://github.com/apache/commons-lang/pull/1553#discussion_r2659900328);
we already have one method per parameter type. Update each method instead of
creating a new test method, this lets us test each method in one place. TY.
##########
src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java:
##########
@@ -5442,6 +5443,11 @@ void testShuffleStringRandom() {
}
}
+ @Test
+ void testShuffleNull() {
+ assertDoesNotThrow(() -> ArrayUtils.shuffle((byte[]) null));
Review Comment:
Hello @rajucomp
See my previous
[comment](https://github.com/apache/commons-lang/pull/1553#discussion_r2659900328);
we already have one method per parameter type. Update each method instead of
creating a new test method. This lets us test each method in one place. TY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
