ujwal2203 commented on PR #1543:
URL: https://github.com/apache/commons-lang/pull/1543#issuecomment-3709129581

   **Summary**
   
   Adjusted ISO-8601 timezone parsing to preserve backward-compatible behavior 
while clarifying supported formats. The change ensures that both 
colon-separated and non-colon timezone offsets continue to be accepted, 
consistent with historical behavior in Commons Lang.
   
   **Testing**
   
   Added a JUnit test method in FastDateParserTest to explicitly cover 
supported ISO-8601 timezone formats:
   
   - Z
   - ±HH
   - ±HHMM
   - ±HH:MM
   - Verified that all existing timezone parsing tests continue to pass.
   
   **Compatibility**
   - Maintains backward compatibility with Commons Lang 3.4 behavior.
   - No change to accepted input formats; parsing behavior remains consistent.
   
   **References**
   
   - Fixes LANG-1805: https://issues.apache.org/jira/browse/LANG-1805
   - Original bug report from 2019 with the documented test case
   - Related to earlier discussion in PR 436
   
   **Checklist**
   
   -  Code follows existing project style
   -  Change is minimal and focused
   -  No new warnings introduced
   -  Tests added to cover supported behaviour
   
   **Why this version is better**
   
   ✔ Matches actual code
   ✔ Mentions test coverage
   ✔ Avoids misleading regex detail
   ✔ Maintainer-friendly
   ✔ Apache-style wording


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to