garydgregory commented on code in PR #825:
URL: https://github.com/apache/commons-io/pull/825#discussion_r2727896494
##########
src/test/java/org/apache/commons/io/FilenameUtilsTest.java:
##########
@@ -192,7 +192,6 @@ void testEqualsNormalized() {
void testEqualsNormalizedError_IO_128() {
assertFalse(FilenameUtils.equalsNormalizedOnSystem("//file.txt",
"file.txt"));
assertFalse(FilenameUtils.equalsNormalizedOnSystem("file.txt",
"//file.txt"));
- assertFalse(FilenameUtils.equalsNormalizedOnSystem("//file.txt",
"//file.txt"));
Review Comment:
Don't delete assertions, instead change it to show the new behavior here.
##########
src/test/java/org/apache/commons/io/FilenameUtilsTest.java:
##########
@@ -450,12 +449,12 @@ void testGetPathNoEndSeparator() {
assertNull(FilenameUtils.getPathNoEndSeparator("1:"));
assertNull(FilenameUtils.getPathNoEndSeparator("1:a"));
assertNull(FilenameUtils.getPathNoEndSeparator("///a/b/c.txt"));
- assertNull(FilenameUtils.getPathNoEndSeparator("//a"));
Review Comment:
Don't delete assertions, instead change it to show the new behavior here.
##########
src/test/java/org/apache/commons/io/FilenameUtilsTest.java:
##########
@@ -775,8 +776,8 @@ void testNormalize() {
assertNull(FilenameUtils.normalize("1:"));
assertNull(FilenameUtils.normalize("1:a"));
assertNull(FilenameUtils.normalize("\\\\\\a\\b\\c.txt"));
- assertNull(FilenameUtils.normalize("\\\\a"));
Review Comment:
Don't delete assertions, instead change it to show the new behavior here.
##########
src/test/java/org/apache/commons/io/FilenameUtilsTest.java:
##########
@@ -986,8 +988,8 @@ void testNormalizeNoEndSeparator() {
assertNull(FilenameUtils.normalizeNoEndSeparator("1:"));
assertNull(FilenameUtils.normalizeNoEndSeparator("1:a"));
assertNull(FilenameUtils.normalizeNoEndSeparator("\\\\\\a\\b\\c.txt"));
- assertNull(FilenameUtils.normalizeNoEndSeparator("\\\\a"));
Review Comment:
Don't delete assertions, instead change it to show the new behavior here.
##########
src/test/java/org/apache/commons/io/FilenameUtilsTest.java:
##########
@@ -317,7 +316,6 @@ void testGetFullPathNoEndSeparator() {
assertNull(FilenameUtils.getFullPathNoEndSeparator("1:"));
assertNull(FilenameUtils.getFullPathNoEndSeparator("1:a"));
assertNull(FilenameUtils.getFullPathNoEndSeparator("///a/b/c.txt"));
- assertNull(FilenameUtils.getFullPathNoEndSeparator("//a"));
Review Comment:
Don't delete assertions, instead change it to show the new behavior here.
##########
src/test/java/org/apache/commons/io/FilenameUtilsTest.java:
##########
@@ -534,7 +534,6 @@ void testGetPrefixLength() {
assertEquals(-1, FilenameUtils.getPrefixLength("1:"));
assertEquals(-1, FilenameUtils.getPrefixLength("1:a"));
assertEquals(-1, FilenameUtils.getPrefixLength("\\\\\\a\\b\\c.txt"));
- assertEquals(-1, FilenameUtils.getPrefixLength("\\\\a"));
Review Comment:
Don't delete assertions, instead change it to show the new behavior here.
##########
src/test/java/org/apache/commons/io/FilenameUtilsTest.java:
##########
@@ -484,7 +483,6 @@ void testGetPrefix() {
assertNull(FilenameUtils.getPrefix("1:"));
assertNull(FilenameUtils.getPrefix("1:a"));
assertNull(FilenameUtils.getPrefix("\\\\\\a\\b\\c.txt"));
- assertNull(FilenameUtils.getPrefix("\\\\a"));
Review Comment:
Don't delete assertions, instead change it to show the new behavior here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
