inponomarev opened a new pull request, #1589: URL: https://github.com/apache/commons-lang/pull/1589
This PR fixes https://issues.apache.org/jira/browse/LANG-1816 ## Changes This PR makes `NaN` handling explicit and consistent across overloads: * Introduced a private helper method `indexOfNaN(double[], int)` that searches for the first `NaN` value. * Updated both `indexOf` overloads (with and without tolerance) to delegate to `indexOfNaN` when `valueToFind` is `NaN`. As a by-product, simplified the linear search in `indexOf` without tolerance by removing the mixed NaN / equality logic. The search now treats `NaN` as a special case in both with/withouth tolerance scenarios rather than attempting meaningless comparisons. Added test cases to cover tolerance search of `NaN` in empty and non-empty arrays. - [X] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [X] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [X] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
