garydgregory commented on PR #1592: URL: https://github.com/apache/commons-lang/pull/1592#issuecomment-3817720820
Hello @ester-bloch -1 as this PR stands: It breaks the build and does not wholly resolve [LANG-1386](https://issues.apache.org/jira/browse/LANG-1386). You must run `mvn` locally by itself before you push to a PR, as described in the PR template. The following methods are in play: - `BooleanUtils.and(boolean...)` - `BooleanUtils.and(Boolean...)` - `BooleanUtils.oneHot(boolean...)` - `BooleanUtils.oneHot(Boolean...)` - `BooleanUtils.or(boolean...)` - `BooleanUtils.or(Boolean...)` - `BooleanUtils.xor(boolean...)` - `BooleanUtils.xor(Boolean...)` The main question IMO is: Should we: - Do nothing, or - Change the `primitive...` vararg parameter to `[]`, or - Change the `Object...` vararg parameter arg to `[]` ? - Changing the `primitive...` arg to `[]` means both new tests compile to the Object API. - Changing the `Object...` arg to `[]` means both new tests compile to the primitive API. Whatever is changed, if anything is changed, needs to be consistent and documented. Obviously, we cannot break binary compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
