peterdemaeyer opened a new pull request, #827:
URL: https://github.com/apache/commons-io/pull/827

   Defined the behavior of `PathUtils.copyDirectory` for symbolic links. It 
depends on the option `LinkOption.NOFOLLOW_LINKS`. Non-symbolic (hard) links 
are out of scope, given that the copy behavior for them was already 
well-defined: they're treated as regular files.
   For the sake of conciseness, the following paragraphs use the term "link" 
for "symbolic link".
   
   Without  `NOFOLLOW_LINKS` option:
   - Links are followed, so that there are no links in the target directory.
   - Cyclic links result in `FileSystemLoopException`.
   - Broken links are ignored, they are not copied at all.
   
   With `NOFOLLOW_LINKS` option:
   - Links are copied as links, so that there are links in the target directory 
for every link in the source directory.
   - Links that link to a file or directory inside the source directory are 
copied to relative links inside the target directory, linking to the copied 
file or directory.
   - Links that link to a file or directory outside the source directory are 
copied to links inside the target directory, linking to the same file or 
directory as the link in the source directory.
   - Cyclic links are preserved, mirrored to cyclic links in the target 
directory.
   - Broken links are ignored, they are not copied at all.
   
   All of this is also explained in the updated JavaDoc.
   
   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       https://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for your contribution to [Apache 
Commons](https://commons.apache.org/)! Your help is appreciated!
   
   Before you push a pull request, review this list:
   
   - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [x] Read the [ASF Generative Tooling 
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use 
Artificial Intelligence (AI).
   - [x] I used AI to create any part of, or all of, this pull request. Which 
AI tool was used to create this pull request, and to what extent did it 
contribute?
   - [x] Run a successful build using the default 
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command 
line by itself.
   - [x] Write unit tests that match behavioral changes, where the tests fail 
if the changes to the runtime are not applied. This may not always be possible, 
but it is a best practice.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body. Note that a maintainer may squash commits during the merge process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to