sebbASF commented on PR #830: URL: https://github.com/apache/commons-io/pull/830#issuecomment-3867069117
Agreed: having the zeros in place shows that they are part of the sequence of values, rather than a special case. This is obvious here: https://github.com/apache/commons-io/blob/4708e989cb6f1e4961ddc365a6c3e31a60d704ec/src/main/java/org/apache/commons/io/EndianUtils.java#L122-L125 Less so here: https://github.com/apache/commons-io/blob/4708e989cb6f1e4961ddc365a6c3e31a60d704ec/src/main/java/org/apache/commons/io/EndianUtils.java#L140 That instance seems to have lots its original layout: https://github.com/apache/commons-io/blob/a330996bf5514705e476d491069b1a4a65794023/src/java/org/apache/commons/io/EndianUtils.java#L390-L393 It might be worth resorting to the original layout throughout, but that is a separate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
