garydgregory commented on code in PR #827:
URL: https://github.com/apache/commons-io/pull/827#discussion_r2798618506
##########
src/main/java/org/apache/commons/io/file/CountingPathVisitor.java:
##########
@@ -304,14 +304,23 @@ protected void updateDirCounter(final Path dir, final
IOException exc) {
}
/**
- * Updates the counters for visiting the given file.
+ * Updates the counters for visiting the given file, ignoring symbolic
links.
+ * <p/>
Review Comment:
You should use open and close tags for a paragraph, not add an empty one.
##########
src/main/java/org/apache/commons/io/file/CountingPathVisitor.java:
##########
@@ -304,14 +304,23 @@ protected void updateDirCounter(final Path dir, final
IOException exc) {
}
/**
- * Updates the counters for visiting the given file.
+ * Updates the counters for visiting the given file, ignoring symbolic
links.
+ * <p/>
+ * According to the JavaDoc, {@link BasicFileAttributes#size} is only
well-defined for regular files.
+ * For symbolic links on Linux for example, it counts the # (charset
dependent?) bytes in the inode name,
+ * which is <i>not</i>> what we want to count here.
Review Comment:
For emphasis, use `<em>`, and let the Javadoc stylesheet decide how to
render it (same for bold, use `<strong>` instead).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
