garydgregory commented on code in PR #424:
URL: https://github.com/apache/commons-codec/pull/424#discussion_r2814274261


##########
src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java:
##########
@@ -182,6 +183,11 @@ void testEdgeCases() throws EncoderException {
     void testExamples() throws EncoderException {
         // @formatter:off
         final String[][] data = {
+            { "aeiou", "0" },
+            { "Ares", "078" },
+            { "abab", "011" },
+            { "m\u00FClhler", "657" },
+            { "m\u00FCleler", "6557" },

Review Comment:
   This is wrong since there are two consecutive 5s. Note the rule "Collapse of 
all multiple consecutive code digits".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to