ilang commented on code in PR #759:
URL: https://github.com/apache/commons-vfs/pull/759#discussion_r3036960653
##########
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpClient.java:
##########
@@ -58,6 +58,32 @@ public interface FtpClient {
*/
boolean completePendingCommand() throws IOException;
+ /**
+ * Changes the current working directory of the FTP session.
+ *
+ * @param relPath The pathname of the directory to change to.
+ * @return true if successfully completed, false if not.
+ * @throws IOException If an I/O error occurs.
+ * @since 2.10.1
Review Comment:
Sorry for the wrong version, I do work with AI, but I closely review it, and
make sure there are tests in place. I guess I missed the version here.
##########
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpClient.java:
##########
@@ -58,6 +58,32 @@ public interface FtpClient {
*/
boolean completePendingCommand() throws IOException;
+ /**
+ * Changes the current working directory of the FTP session.
+ *
+ * @param relPath The pathname of the directory to change to.
+ * @return true if successfully completed, false if not.
+ * @throws IOException If an I/O error occurs.
+ * @since 2.10.1
+ */
+ default boolean changeDirectory(String relPath) throws IOException {
+ return false;
+ }
+
+ /**
+ * Tests whether a remote path is an existing directory by attempting to
CWD into it.
+ * Implementations must save and restore the working directory to avoid
side effects
+ * on subsequent operations that use relative paths.
+ *
+ * @param relPath The pathname to test.
+ * @return true if the path is an existing directory, false otherwise.
+ * @throws IOException If an I/O error occurs.
+ * @since 2.10.1
Review Comment:
Sorry for the wrong version, I do work with AI, but I closely review it, and
make sure there are tests in place. I guess I missed the version here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
