garydgregory commented on code in PR #1623:
URL: https://github.com/apache/commons-lang/pull/1623#discussion_r3044706243
##########
src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java:
##########
@@ -887,6 +889,9 @@ void testIsCreatable() {
compareIsCreatableWithCreateNumber(".D", false); // LANG-1646
compareIsCreatableWithCreateNumber(".e10", false); // LANG-1646
compareIsCreatableWithCreateNumber(".e10D", false); // LANG-1646
+ compareIsCreatableWithCreateNumber("1E-2147483648", false);
+ compareIsCreatableWithCreateNumber("1E2147483648",
SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_21));
Review Comment:
You need more tests around the edge cases.
TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
