ppkarwasz commented on code in PR #636:
URL:
https://github.com/apache/commons-configuration/pull/636#discussion_r3225948650
##########
src/main/java/org/apache/commons/configuration2/io/AbstractFileLocationStrategy.java:
##########
@@ -204,6 +205,55 @@ public T get() {
*/
private static final String KEY_SCHEMES =
"org.apache.commons.configuration2.io.FileLocationStrategy.schemes";
+ private static void checkHost(String value, final Set<Pattern> validSet) {
Review Comment:
Shouldn't this also be a checkstyle or PMD rule?
Fixed in
https://github.com/apache/commons-configuration/pull/636/commits/27a7746c4aa7e1a3a15b1b9629c4e245f2be83a1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
