dxbjavid commented on PR #323: URL: https://github.com/apache/commons-math/pull/323#issuecomment-4591877411
Good catch on the exception value. Widened begin + length to long in the message args for both verifyValues and setData, so it now reports 2147483648 instead of the wrapped int. Added testVerifyValuesOverflow, which calls verifyValues(testArray, 1, Integer.MAX_VALUE). Before the fix the int sum wraps negative, the bounds check is skipped, and it returns true instead of throwing, so the test fails. It also asserts getArgument() is the correct long value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
