sahvx655-wq commented on PR #394: URL: https://github.com/apache/commons-validator/pull/394#issuecomment-4655945189
Good catch. I've dropped the literal strings and built the input from `BigInteger.valueOf(Long.MAX_VALUE).add(BigInteger.ONE)`, so it's the first value that can't fit in a long and is provably above the boundary rather than a hand-counted digit string. The two assertions stand on their own now: the result has to compare greater than Long.MAX_VALUE (the old code clamped it exactly there), and it has to agree with what BigDecimalValidator returns for the same input. I reran it against the unpatched processParsedValue to confirm it still fails there and passes after the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
