rootvector2 opened a new pull request, #608:
URL: https://github.com/apache/commons-csv/pull/608

   `isEscapeDelimiter()` peeks the next characters into the reused 
`escapeDelimiterBuf` look-ahead without clearing it first, so a truncated 
escaped multi-character delimiter at EOF is completed from the stale bytes of 
an earlier full escaped delimiter and the lexer appends a delimiter the input 
never contained. clearing the buffer before the peek mirrors the `delimiterBuf` 
reset added in `nextToken` for the plain multi-character delimiter path.
   
   found while reading the partial-delimiter-at-EOF fix (CSV-324): the 
escaped-delimiter sibling was left unguarded.
   
   for delimiter `[|]` and escape `!`, parsing `x![!|!]y![!|` returns 
`x[|]y[|]` before the change and the correct `x[|]y![!|` after. regression 
tests added in `LexerTest` and `CSVParserTest` (both fail without the one-line 
change).
   
   - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [ ] Read the [ASF Generative Tooling 
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use 
Artificial Intelligence (AI).
   - [ ] I used AI to create any part of, or all of, this pull request. Which 
AI tool was used to create this pull request, and to what extent did it 
contribute?
   - [ ] Run a successful build using the default 
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command 
line by itself.
   - [x] Write unit tests that match behavioral changes, where the tests fail 
if the changes to the runtime are not applied. This may not always be possible, 
but it is a best practice.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body. Note that a maintainer may squash commits during the merge process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to