dxbjavid opened a new pull request, #753:
URL: https://github.com/apache/commons-text/pull/753
CaseUtils.toCamelCase and WordUtils.capitalizeFully fold their input to
lower case with the no-arg String.toLowerCase(), so the output depends on the
JVM default locale; under a Turkish locale an ASCII 'I' becomes the dotless 'ı'
(U+0131), so capitalizeFully("HELI WORLD") comes back as "Helı World" rather
than "Heli World" and toCamelCase("TIP.TOP", true, '.') yields "TıpTop".
StringLookupFactory has the same issue when it upper-cases the default-lookups
system property to match the enum names, which can stop a valid value like
"file" from resolving on a Turkish JVM. I have switched all three sites to
Locale.ROOT, matching the Locale.ROOT already used in
StringLookupFactory.toKey, and added tests that pin the behaviour under a
Turkish default locale.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
