CptBartender commented on PR #1704: URL: https://github.com/apache/commons-lang/pull/1704#issuecomment-4701802442
I took a swing at one of the issues from Jira, and here's my proposed approach on how to tackle that. My general idea is that the `stringBuilder` param is _null-safe_ and providing `null` there results in the same result as if the other overload was called instead. Also, contrary to the proposed approach in the ticket, I'm suggesting we return the `StringBuilder` instance so that we can fluently use it, if needed. I've done the overloads only for `boolean[]` joining, as I didn't want to commit too much time if this approach is not deemed acceptable - once confirmed, I'm happy to provide similar overloads for other cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
