sahvx655-wq opened a new pull request, #398: URL: https://github.com/apache/commons-validator/pull/398
Both `CASNumberCheckDigit.isValid` and `ECNumberCheckDigit.isValid` pass the argument through `REGEX_VALIDATOR`, which is a `CodeValidator` and so trims the input and drops the dash separators before matching. The check digit is then read back from `code.charAt(code.length() - 1)` on the untouched argument. I tripped over this feeding values from a data column that still had trailing spaces: `"7732-18-5 "` is rejected while `" 7732-18-5"` passes, so validity ends up depending on which side a stray space happens to sit. The string returned by the validator is already trimmed and de-formatted, and its last character is the check digit, so the comparison belongs on that value rather than the raw argument. Reading both the modulus input and the check digit from the validated string removes the asymmetry and keeps the two routines consistent with the trimming the format validator already does everywhere else. Left as is, valid CAS and EC numbers are quietly rejected whenever the caller has not stripped trailing whitespace first. Before you push a pull request, review this list: - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
