alhudz opened a new pull request, #1712:
URL: https://github.com/apache/commons-lang/pull/1712
Repro: `NumberUtils.createNumber("0xFFFFFFFFFFFFFFFFL")` throws
`NumberFormatException: For input string: "FFFFFFL"`.
Expected: a `BigInteger` of `0xFFFFFFFFFFFFFFFF`, the same result as
`createNumber("0xFFFFFFFFFFFFFFFF")` (no suffix) and the decimal path
`createNumber("9223372036854775808L")`.
Cause: the hex branch that is too large for a `Long` calls
`createBigInteger(str)` with the `L`/`l` type suffix still attached.
`createBigInteger` strips only the radix prefix and then runs `new
BigInteger(substring, 16)`, so the trailing `L` reaches the hex parser and is
rejected. The decimal branch already drops the suffix before its `BigInteger`
fallback, which is why only the hex form throws.
Fix: drop the trailing type char before the `createBigInteger` fallback when
the literal carries one, so an over-long hex literal with a suffix parses the
same as the unsuffixed form.
Covers the `0x`/`0X`/`#` prefixes, signed and unsigned. Regression
assertions added to `NumberUtilsTest.testCreateNumber`; they fail with
`NumberFormatException` before the change and pass after.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [ ] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
