rootvector2 opened a new pull request, #611: URL: https://github.com/apache/commons-csv/pull/611
`isDelimiter` peeks the next characters into the reused `delimiterBuf` look-ahead buffer without clearing it, so a non-matching peek earlier in the same token leaves stale chars in the trailing positions and a truncated multi-character delimiter at EOF false-matches. With delimiter `[|]`, input `x[a][|` is split into `x[a]` and an empty field, because the earlier `[a]` peek left `]` in the buffer and the trailing `[|` (only two of the three delimiter chars present before EOF) matches against that stale `]`. CSV-324 cleared `delimiterBuf` once per `nextToken`, but `isDelimiter` peeks repeatedly within a token, so the reset has to happen before the peek, the same way `isEscapeDelimiter` already does it; the once-per-token clear is then redundant and dropped. Found while auditing the multi-character delimiter look-ahead after CSV-324. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
