OldTruckDriver opened a new pull request, #435:
URL: https://github.com/apache/commons-codec/pull/435

   ## Summary
   
   Fix `Base32.Builder#setHexDecodeTable(boolean)` so it configures the 
matching Base32/Base32-Hex encode table instead of passing a decode lookup 
table to `setEncodeTable(byte...)`.
   
   ## Details
   
   The previous implementation passed `decodeTable(useHex)` into 
`setEncodeTable(...)`. Used on its own, this made the codec encode with a 
decode lookup table and emit invalid bytes.
   
   This change updates `setHexDecodeTable(boolean)` to use 
`encodeTable(useHex)` and adds a regression test proving the configured codec 
encodes with the Base32-Hex alphabet and decodes its own output.
   
   ## Tests
   
   - `mvn -q -Dtest=org.apache.commons.codec.binary.Base32Test test`
   - `mvn -q javadoc:javadoc`
   - `mvn -q`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to