OldTruckDriver opened a new pull request, #437: URL: https://github.com/apache/commons-codec/pull/437
## Summary Fix `Base58.Builder#setEncodeTable(byte...)` so custom Base58 alphabets are used consistently for encoding, decoding, leading zero handling, and alphabet checks. ## Details Previously, the builder accepted a custom encode table, but `Base58` still used the built-in static encode/decode tables internally. This meant custom alphabets were silently ignored. This change derives a matching decode table from custom 58-byte alphabets, validates alphabet length and duplicate entries, and uses the configured alphabet throughout Base58 operations. ## Tests - `mvn -q -Dtest=org.apache.commons.codec.binary.Base58Test test` - `mvn -q '-Dtest=org.apache.commons.codec.binary.Base58*Test' test` - `mvn -q javadoc:javadoc` - `mvn -q` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
