s8sankalp opened a new pull request, #689: URL: https://github.com/apache/commons-collections/pull/689
Restore test coverage for Map entrySet and values views that was dropped during the JUnit 5 migration. ### Changes * Convert `MapEntrySetTest` and `MapValuesTest` in `AbstractMapTest` to concrete classes annotated with `@Nested` so they are discovered and executed by JUnit 5. * Update `bulkTestMapEntrySet` and `bulkTestMapValues` to return direct instances. * Modify visibility of `testUnsupportedRemove` and `testUnsupportedAdd` in `AbstractCollectionTest` from package-private to `public` to allow package-cross overrides. * Shadow `MapValuesTest` in `CompositeMapTest` to override `testUnsupportedRemove` due to `CompositeCollection` custom removal behavior. * Remove incorrect `isEntrySetAddSupported` override in `ConcurrentHashMapSanityTest` and shadow `MapEntrySetTest` to bypass `testUnsupportedAdd` since `ConcurrentHashMap.entrySet().add()` is supported in standard Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
