rootvector2 opened a new pull request, #400: URL: https://github.com/apache/commons-beanutils/pull/400
Port of #399 to the `1.X` branch. `DecimalLocaleConverter.parse` calls `DecimalFormat.parse(String)`, which stops at the first character it cannot read and silently drops the rest, so a locale numeric conversion of `123abc` returns `123` and `42 OR 1=1` returns `42`. Every numeric locale converter (`Byte`/`Short`/`Integer`/`Long`/`Float`/`Double`/`BigDecimal`/`BigInteger`) routes through this one method, while the sibling `DateLocaleConverter` already rejects leftover input with a `ParsePosition` check. Switched to that same form so the whole string must be consumed, otherwise `ParseException` is thrown. Added `DecimalLocaleConverterTest` (fails without the runtime change) and updated the now-stale `(B)` assertions across the numeric locale converter tests, which pinned `DecimalFormat`'s old partial-parse values and now fall through to the converter default. `mvn test -Dtest='*LocaleConverterTest'` is green (104 tests). The only failure in a full `mvn` run is `LocaleBeanificationTest.testContextClassloaderIndependence`, which is a pre-existing flake unrelated to this change (it fails the same way on a clean `1.X` checkout and installs its own mock converters that bypass real parsing). - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
