rootvector2 opened a new pull request, #401: URL: https://github.com/apache/commons-beanutils/pull/401
`BigIntegerLocaleConverter` and `BigDecimalLocaleConverter` derive their result from the `Long`/`Double` that `DecimalLocaleConverter.parse` returns because `setParseBigDecimal` is never enabled, so a value past `long`/`double` range comes back silently wrong (`9999999999999999999` becomes `9223372036854775807` for `BigInteger` and `1.0E+19` for `BigDecimal`); enabling `setParseBigDecimal` only for those two converters via an `isParseBigDecimal()` hook keeps the parse lossless while the narrowing `Byte`/`Short`/`Integer`/`Long`/`Float`/`Double` converters (and `DoubleLocaleConverter`'s `(Double)` cast) are untouched, found by comparing the locale converters with the non-locale `BigInteger`/`BigDecimal` converters that parse the string directly. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
