aherbert commented on PR #695: URL: https://github.com/apache/commons-collections/pull/695#issuecomment-4807436204
I'd rather deal with this with no code changes. IMO the Bloom filter is used by someone with control of the entire stack that creates hashes. This should never happen in real use. The ``isValid`` flag in the ``CountingBloomFilter`` is to satisfy a real use case where you may add too many items to count. Moving it to ``BloomFilter`` to satisfy cases that will not happen in practical use is overkill. I think this package could do with more javadoc to indicate that the filter merge operates using non-atomic additions of a set of indices. By design this is not meant to be recoverable if an exception occurs during the merge. Exceptions are a sign of misuse with bad indices. They should not be ignored by the user and a filter that emits an exception is considered invalid due to potentially containing bits not corresponding to a valid hash. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
