UriParser.canonicalizePath possible NPE for filenameParser
----------------------------------------------------------
Key: VFS-327
URL: https://issues.apache.org/jira/browse/VFS-327
Project: Commons VFS
Issue Type: Bug
Reporter: Sebb
The UriParser.canonicalizePath method has a possible NPE for filenameParser:
{code}
[495] boolean match = value == '%'
[496] || (fileNameParser != null &&
fileNameParser.encodeCharacter(value));
...
[511] else if (fileNameParser.encodeCharacter(ch))
{code}
Line 496 allows for fileNameParser being null, but line 511 does not.
As far as I can tell, the method is never called with a null parser, so it
should be safe to omit the null check in line 496.
If the code can ever be called with a null parser, then the code at line 511
needs to be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
