alhudz opened a new pull request, #1738: URL: https://github.com/apache/commons-lang/pull/1738
`Repro:` `formatDuration(Duration.ofHours(5).toMillis(), "HxH", false)` returns `5x`, and `formatDuration(Duration.ofDays(2).toMillis(), "d-d", false)` returns `2-`. `Expected:` `5x5` and `2-2` — the field letter on each side of the literal is a separate field. `Actual:` the trailing field is dropped and folded into the first token, whose pad width silently grows. `Cause:` `lexx` keeps a `previous` pointer so adjacent identical field letters (`HH`) collapse into one padded token, but it never clears that pointer when a non-field character is seen. The run therefore leaks across a plain literal, a quoted literal, and `[`/`]` blocks, so `HxH` merges the two `H`s while `HmH` (separated by another field) does not. `Fix:` reset `previous` in the `[`, `]`, quote and default branches so a run only collapses when the letters are truly adjacent. `HH` still collapses; `H'x'H`, `H[x]H` and `d-d` no longer do. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
