kali834x opened a new pull request, #779:
URL: https://github.com/apache/commons-compress/pull/779

   readDirectoryEntry computes datalen as `TP_SIZE * entry.getHeaderCount()` in 
int, but the header count comes straight from the tape segment header and isn't 
bounded at that point, so a directory inode claiming around 2^21 records wraps 
the product to a negative value that then flows into `raw.read(blockBuffer, 0, 
datalen)` and surfaces as an `IndexOutOfBoundsException` rather than a normal 
archive error. getNextEntry already rejects a count `>= CDATA_LEN` and the 
sibling skip sites in getNextEntry, readBITS and readCLRI cast to long, so this 
one path is the odd one out; applying the same bound before the multiply keeps 
a corrupt count from reaching the size math. this is the COMPRESS-712 testPart2 
input, whose assertion moves from the raw `IndexOutOfBoundsException` to an 
`ArchiveException`.
   
   - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [ ] Read the [ASF Generative Tooling 
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use 
Artificial Intelligence (AI).
   - [ ] I used AI to create any part of, or all of, this pull request. Which 
AI tool was used to create this pull request, and to what extent did it 
contribute?
   - [x] Run a successful build using the default 
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command 
line by itself.
   - [x] Write unit tests that match behavioral changes, where the tests fail 
if the changes to the runtime are not applied.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to