sahvx655-wq opened a new pull request, #416: URL: https://github.com/apache/commons-validator/pull/416
The DoubleValidator range fix in #410 left the same narrowing in the shared parent. `AbstractNumberValidator.minValue(Number, Number)` and `maxValue(Number, Number)` fall back to `value.longValue()` against `min.longValue()` on the integer branch, and `ByteValidator`, `ShortValidator`, `IntegerValidator` and `LongValidator` inherit that branch without overriding it, so a bound that does not fit in a long is mangled before the comparison ever happens. `LongValidator.maxValue(Long.MAX_VALUE, 2^63 held as a BigInteger)` narrows the bound to `Long.MIN_VALUE` and reports the in-range value as over the maximum, while a fractional bound such as `minValue(5, 5.5)` is floored to 5 and wrongly passes. The visible behaviour is a validator quietly comparing against the wrong bound whenever a small integer value meets a `BigInteger`, `BigDecimal` or fractional limit, which is easy to miss because no error is raised. The `BigInteger`, `BigDecimal` and `Double` overloads already compare the operands exactly and keep the `doubleValue()` fallback for a non-finite bound, so I put the same treatment on the parent's integer branch rather than repeat an override in all four subclasses. Sitting the fix in the shared base keeps the `NaN` and infinity handling identical across the hierarchy and avoids a fifth copy of the comparison. Each of the four affected validator tests gets a regression that fails on the old narrowing branch and passes now. Before you push a pull request, review this list: - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
