rootvector2 opened a new pull request, #516: URL: https://github.com/apache/commons-bcel/pull/516
`BootstrapMethod.copy()` is documented as a deep copy but returns `clone()`, which leaves the copy sharing the mutable `bootstrapArguments` int[] with its source; the copy constructor `BootstrapMethod(BootstrapMethod)` shares it too. Because `getBootstrapArguments()` returns the raw array, `setBootstrapArguments` swaps it, and `dump()` writes it, mutating a copied entry's arguments silently rewrites the original's dumped bytes. Found while checking the per-entry `copy()` contracts against `StackMapEntry.copy()`, which reallocates its arrays. Cloning the int[] in both copy paths makes each copy independent. `ModuleExports`/`ModuleOpens`/`ModuleProvides` also `clone()` an int[], but keep it `final` with no raw getter or setter, so their aliasing is not observable and is left unchanged. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
