rootvector2 commented on PR #407: URL: https://github.com/apache/commons-beanutils/pull/407#issuecomment-4886482099
Traced it. The warnings come from the `commons-collections4` 4.5.0 tests jar, not from beanutils: `BeanMapTest` extends `org.apache.commons.collections4.map.AbstractMapTest`, and in 4.5.0 its `TestMapEntrySet`/`TestMapKeySet`/`TestMapValues` are concrete non-static inner classes left over from the JUnit 3 `BulkTest` mechanism. JUnit platform 5.13+ flags inherited member classes that have test methods but are neither static nor `@Nested`, so they show up whenever `BeanMapTest` is discovered. The warning is accurate, those entrySet/keySet/values suites don't actually run under Jupiter with 4.5.0. Already fixed on collections master: apache/commons-collections#681 and apache/commons-collections#689 (COLLECTIONS-884) renamed them to `MapEntrySetTest`/`MapKeySetTest`/`MapValuesTest` and made them `@Nested`, so the warnings go away once beanutils picks up collections4 4.6.0. One thing to watch: at that point the view suites will start executing against `BeanMap`, so the bump may need some test adjustments. Reproduced on `1.X` with `mvn test -Dtest=BeanMapTest`; surefire puts the log in the `*-output.txt` reports rather than the console. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
