s8sankalp commented on PR #694: URL: https://github.com/apache/commons-collections/pull/694#issuecomment-4886754961
hi @garydgregory I have addressed all the remaining Copilot review findings: 1. **Corrected Misleading Comments in `PassiveExpiringMapTest`**: Updated the comments in `testCollectionsSynchronizedMapExpiration()` from `"iterator triggers expiration"` to `"view access triggers expiration"` (for `entrySet`, `keySet`, and `values`). This accurately reflects that the assertions verify expiration using `.isEmpty()` on the cached view rather than an iterator. 2. **Local Verification**: Checkstyle has 0 violations and all 19,894 tests in the suite pass successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
