rootvector2 opened a new pull request, #411: URL: https://github.com/apache/commons-beanutils/pull/411
The integer locale converters `IntegerLocaleConverter`, `LongLocaleConverter`, `ShortLocaleConverter`, `ByteLocaleConverter` and `BigIntegerLocaleConverter` parse with a `DecimalFormat` that accepts a fractional part, then narrow the result with `intValue()`/`longValue()`/`byteValue()`/`toBigInteger()`. Their only guard checks that the value fits the target range, so `5.5` slips through and is silently truncated to `5` instead of rejected. Found by diffing them against the non-locale `IntegerConverter`, which rejects `5.5` through `Integer.valueOf`. Each `parse` now rejects a non-integer result before narrowing, and `BigIntegerLocaleConverter` uses `toBigIntegerExact`. Grouping separators and large in-range integers still convert. The stale `(B)` assertions that pinned the old truncated values now expect the default. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
