rootvector2 opened a new pull request, #771: URL: https://github.com/apache/commons-vfs/pull/771
`ExceptionConverter.generate` turns a WebDAV server's DAV error response into a `FileSystemException` and hands the response's `<exception><class>` text straight to `Class.forName(...).getConstructor(String.class).newInstance(msg)`, so a malicious or compromised server can make the client load and construct any class on its classpath (CWE-470). Found while auditing the webdav providers for untrusted-input reflection sinks. The fix loads the named class without initializing it and only constructs it when it is an `Exception` subtype, which keeps reconstruction of genuine server exception types working while refusing everything else. The jackrabbit1 (`webdav`) and jackrabbit2 (`webdav4`) providers carry the same sink, so both are fixed; the new `ExceptionConverterTest` cases fail on the current code (the crafted class name is instantiated) and pass with the change. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
