rootvector2 opened a new pull request, #705: URL: https://github.com/apache/commons-collections/pull/705
`add(Object, int)` in `AbstractMapBag` and `AbstractMapMultiSet` accumulates the running `size` and the per-element count into plain `int` fields with no upper bound, so a second `add` whose total crosses `Integer.MAX_VALUE` overflows both: `add(x, Integer.MAX_VALUE)` then `add(x, 1)` leaves `getCount(x) == Integer.MIN_VALUE` and `size()` negative. Clamp both to `Integer.MAX_VALUE` inside `add()`, matching the `Collection.size()` contract and the existing `BloomFilter`/`CompositeMap.size()` idiom. Found while auditing the bag/multiset count arithmetic; the regression tests in `HashBagTest` and `HashMultiSetTest` fail before the change (`-4` / `Integer.MIN_VALUE`) and pass after. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
