rootvector2 opened a new pull request, #621: URL: https://github.com/apache/commons-csv/pull/621
`printWithQuotes` decides MINIMAL-mode encapsulation from the first and last character, but only against ascii bounds: `c <= Constants.COMMENT` for the leading char and `isTrimChar` (`c <= ' '`) for the trailing one. The parser's `ignoreSurroundingSpaces` strips any `Character.isWhitespace` on read, and several whitespace code points sit above `' '` (U+3000 ideographic space, U+2028/U+2029, U+2003, U+1680, U+205F, U+2000..U+200A). A value bounded by one of them, such as `ćać`, is written unquoted and read back trimmed to `a`. Quote when the first or last character is `Character.isWhitespace`, matching what the reader trims. `isTrimChar` is left alone since it is shared with the `getTrim` path that mirrors `String.trim`. Found while round-tripping unicode whitespace through the printer with `ignoreSurroundingSpaces`. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
