garydgregory commented on code in PR #706:
URL:
https://github.com/apache/commons-collections/pull/706#discussion_r3555279376
##########
src/main/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMap.java:
##########
@@ -337,6 +344,10 @@ public void remove() {
it.remove();
}
+ /**
+ * @throws UnsupportedOperationException always, as this method is not
supported
Review Comment:
Missing inherit tag.
##########
src/main/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMap.java:
##########
@@ -285,6 +285,13 @@ private final class MultiValuedMapEntry extends
AbstractMapEntry<K, V> {
super(key, value);
}
+ /**
+ * {@inheritDoc}
+ * <p>
+ * This implementation always throws an {@link
UnsupportedOperationException}
+ * as modification of the entry is not supported.
+ * </p>
+ */
Review Comment:
That's not how to document exceptions in Javadoc, you need to read
https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#@exception
and use `@throws`.
##########
src/main/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMapDecorator.java:
##########
@@ -130,6 +130,13 @@ public Set<K> keySet() {
return decorated().keySet();
}
+ /**
+ * {@inheritDoc}
+ * <p>
Review Comment:
See above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
