kali834x opened a new pull request, #783: URL: https://github.com/apache/commons-compress/pull/783
the array-count form of decodeBandInt in BandSet slices a flat band into per-entry arrays but only rejects a counts[i] larger than the decoded length, never a negative one. a per-entry count read through UNSIGNED5 can pass Integer.MAX_VALUE and narrow to a negative int in BHSDCodec.decode, so a crafted pack200 archive whose counts still sum to a positive total reaches new int[counts[i]] and surfaces a NegativeArraySizeException instead of a Pack200Exception. the single-count decodeBandInt already guards count < 0; the same guard is added to the array form, which is what ClassBands feeds for class_attr_indexes and the line-number and local-variable tables. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
