rootvector2 opened a new pull request, #520: URL: https://github.com/apache/commons-bcel/pull/520
`InstConstraintVisitor` checks the primitive array load/store instructions with `ArrayType.getBasicType()`, which returns the innermost basic type and drops the dimension count, so `iaload`/`iastore` (and the `long`/`float`/`double`/`short` variants) applied directly to a multidimensional primitive array such as `int[][]` pass Pass3b even though the component type is `int[]`, a reference. The reference/byte/char siblings (`aaload`/`aastore`, `baload`/`bastore`, `castore`) already use `getElementType()`; this switches the ten primitive `*aload`/`*astore` checks to match. For a one-dimensional array `getElementType()` returns the same object as `getBasicType()`, so valid code verifies exactly as before. Found while auditing the `*ALOAD`/`*ASTORE` element-type checks against `ArrayType`. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
