rootvector2 opened a new pull request, #522: URL: https://github.com/apache/commons-bcel/pull/522
`InstConstraintVisitor.visitCALOAD` only checks that the arrayref is some array, never that its component type is `char`, so Pass3b structural verification accepts `caload` on any array such as an `int[]` or a reference array like `String[]`. `ExecutionVisitor.visitCALOAD` then models the loaded value as `int`, so a reference read through `caload` is type confused as an int while the class still verifies. Found by comparing `visitCALOAD` against its store counterpart `visitCASTORE` just below it, which does check `char`. Add the same component-type check that `visitCASTORE` uses so the constraint sits next to the other array-access checks in the structural pass. `TestArrayAccess06` applies `caload` to an `int[]` and asserts verification rejects it. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
