kali834x opened a new pull request, #786: URL: https://github.com/apache/commons-compress/pull/786
parseFileFormat in X0017_StrongEncryptionHeader passes the raw ivSize/erdSize/hashSize/resize/vSize fields as the third argument to Arrays.copyOfRange, which is an end index and not a length, so every other extra-field parser in this package uses the offset+length form instead. a crafted 0x0017 local extra field where the recipient key hash starts past hashSize makes copyOfRange throw IllegalArgumentException (fromIndex > toIndex), and fillExtraField only maps ArrayIndexOutOfBoundsException to ZipException, so that runtime exception escapes uncaught out of ZIP parsing; the earlier fields are also sliced to the wrong length. compute each end index as from + size and drop the assertMinimalLength guards that only existed to dodge the from > to case, the surviving assertDynamicLengthFits/prefix checks already bound every slice so malformed input now surfaces as the declared ZipException. added X0017_StrongEncryptionHeaderTest covering the recipient-key-hash case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
