rootvector2 opened a new pull request, #523: URL: https://github.com/apache/commons-bcel/pull/523
The `count` operand of `invokeinterface` and the `dimensions` operand of `multianewarray` are each a u1 (1-255), but `INVOKEINTERFACE(int, int)` and `MULTIANEWARRAY(int, short)` only check the lower bound (`nargs < 1` / `dimensions < 1`) while their `dump()` writes the field with `out.writeByte(...)`. A value in 256-32767 is accepted and returned by `getCount()`/`getDimensions()`, but truncated to its low 8 bits on dump, so the emitted instruction carries a different count than requested (e.g. `260` is written as `4`). Found while sweeping the generation-side `writeByte` sites after #506 fixed the u2 index setters. Adds the matching `> Const.MAX_BYTE` guard to both constructors; `IINC`/`RET`/`LDC` already pick a wider form so they are unaffected. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
