alhudz commented on PR #1750: URL: https://github.com/apache/commons-lang/pull/1750#issuecomment-5010650141
Thanks for the merge. I went back over the class with the same `Integer.MIN_VALUE`/`MAX_VALUE` probes and didn't find another escape: `subarray` already clamps with `max0`, `shift` returns early on `endIndexExclusive <= 0` before any subtraction, `swap` runs `max0` on both offsets and bounds `len` by the remaining lengths, and `indexOf`/`lastIndexOf` (including the NaN and tolerance variants) either clamp or bail on a negative start. `add(index)`, `insert` and `remove` throw `IndexOutOfBoundsException` by documented contract, so `reverse` looks to have been the only spot where an extreme value got past the clamps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
