alhudz commented on PR #1749: URL: https://github.com/apache/commons-lang/pull/1749#issuecomment-5010649295
Thanks for merging this. Nothing new at the moment: the other shift issues I'd found are already in (#1711 for the int mask sign extension in the `long` methods, #1751 for the `FluentBitSet.setInclusive` overflow). I had another look at `Conversion` and `CachedRandomBits`; both mask after the arithmetic shift (`0xff & src >> shift` style), so sign extension can't leak out there. If anything else turns up at the top-bit boundaries I'll open a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
