rootvector2 commented on PR #714: URL: https://github.com/apache/commons-collections/pull/714#issuecomment-5010687564
went through the other `EntrySet.remove` implementations: `AbstractHashedMap` and `AbstractPatriciaTrie` guard with `contains(obj)`, `TreeBidiMap` (both views), `AbstractDualBidiMap`, `PassiveExpiringMap` and `ListOrderedMap` all check the value, `StaticBucketMap` compares entries via `Node.equals` (key and value), and `ConcurrentReferenceHashMap` delegates to `remove(key, value)`. `Flat3Map` was the only one removing on key alone, so nothing else needs fixing. noted on `changes.xml`, will leave it out going forward. thanks for merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
