kali834x commented on PR #787: URL: https://github.com/apache/commons-compress/pull/787#issuecomment-5017234439
Thanks for merging. I went through the rest of the extra field parsers in the zip package (x0014, x0017, x0019, x000a ntfs, x5455, x7875, zip64, 0xa11e resource alignment, ASi, unicode path/comment) against their documented layouts and didn't find any other Short/Long width mismatches. x0017 already reads rcount as 4 bytes in both the central directory and local file paths, and the others either have no fixed numeric fields or read exactly the widths their specs give. The only thing I noticed is the offset arithmetic in X0017.parseFileFormat that the existing TODO comments already question, but that's about offset constants rather than field widths. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
