rootvector2 opened a new pull request, #774: URL: https://github.com/apache/commons-vfs/pull/774
`UriParser.decode` and `canonicalizePath` parse the two digits of a `%XX` escape with `Character.digit(ch, 16)`, which accepts non-ascii look-alikes such as the fullwidth digits and arabic-indic digits, not just the ascii `HEXDIG` that RFC 3986 permits, so the fullwidth form of `%2e%2e%2f` decodes to `../` and slips past any ascii filter run on the raw string. Found while auditing the percent-decode path after the recent VFS-863 bracket change. The fix routes both nibbles through a small ascii-only `hexDigit` helper so a non-ascii digit raises the existing `invalid-escape-sequence` error and valid `%XX` decoding is unchanged; the new `UriParserTest` cases fail on the current code and pass with the change. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
