[ 
https://issues.apache.org/jira/browse/MATH-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929393#action_12929393
 ] 

Phil Steitz commented on MATH-433:
----------------------------------

As I said on the ML, I am not in favor of this change, pretty much for the 
reasons that Luc points out.  Also, to do this consistently, we would have to 
trap every floating point computation (essentially introduce floating point 
versions of the mulAndCheck, addAndCheck, etc in MathUtils) that we do 
throughout the library,  which would have significant performance impacts. 

> Signal overflow by raising an exception
> ---------------------------------------
>
>                 Key: MATH-433
>                 URL: https://issues.apache.org/jira/browse/MATH-433
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Gilles
>            Priority: Minor
>
> Referring to the ML thread (with subject "Factorial").
> Shouldn't Commons-Math always raise an exception when overflow is detected, 
> including in cases where the Java language specification has decided to 
> return infinity?
> It was argued, in the ML thread on "FunctionEvaluationException", that it was 
> much better to raise an exception than to rely on special values to detect 
> problems. I think that the same argument fits perfectly in this case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to