sahvx655-wq commented on PR #429: URL: https://github.com/apache/commons-validator/pull/429#issuecomment-5056637130
Those five are all general category Cf, so the FORMAT check from #420 (which this PR keeps) already rejects them before the new branch is even consulted. When I walked RFC 3454 Table B.1 against Character.getType, the Cf entries were exactly what the existing guard caught; the leftovers were U+034F (Mn), U+1806 (Pd), U+180B..U+180D and U+FE00..U+FE0F (Mn), and those are what isNameprepMappedToNothing adds. Any of them alone is enough to make a byte-distinct host validate as the clean label, so the two checks together should now cover the whole mapped-to-nothing table. testIDNFormatCodePoints already pinned 00AD, 200B, 200D and FEFF; 200C was the one from your list without an explicit assertion, so I've pushed a one-line addition covering it. DomainValidatorTest is green with all of them asserted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
